wallace added inline comments.
================
Comment at:
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/set/TestDataFormatterGenericSet.py:45
"[3] = 3",
"[6] = 6"])
----------------
danilashtefan wrote:
> wallace wrote:
> > can you add additional assertions like the one you did in
> > https://reviews.llvm.org/D112180 that uses ValueCheck?
> I have made check method more generic and less verbose. Before it was
> specifically checking the "ii" variable, that was a set<int> of size 7. With
> value check approach we can now test set<string> and others.
>
> I guess, that I can delete all of the
> ```
> self.expect()
> ```
> and simply call check method with the expected size. Please, let me know if I
> should do it or leave it as it is. Thanks
yes, the code is good as you did it
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112537/new/
https://reviews.llvm.org/D112537
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
