wallace added a comment.
just some minor things left
================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:941-942
new StringSummaryFormat(stl_summary_flags, "size=${svar%#}")));
+ TypeSummaryImpl::Flags stl_set_summary_flags = stl_summary_flags;
+ stl_set_summary_flags.SetSkipPointers(false).SetDontShowValue(false);
+ cpp_category_sp->GetRegexTypeSummariesContainer()->Add(
----------------
to mimic the libcxx case that you can see in the line 710 of
https://lldb.llvm.org/cpp_reference/CPlusPlusLanguage_8cpp_source.html, you can
do stl_summary_flags.SetSkipPointers(false) in line 932 of this file. Then both
standard libraries will be handled the same way. Make sure to execute the
relevant tests for vector, map, set and list for libstdcpp.
This also means that you don't need the new variable stl_set_summary_flags
================
Comment at:
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/set/Makefile:4
-CXXFLAGS_EXTRAS := -O0
+
include Makefile.rules
----------------
remove this line
================
Comment at:
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/set/TestDataFormatterGenericSet.py:45
"[3] = 3",
"[6] = 6"])
----------------
can you add additional assertions like the one you did in
https://reviews.llvm.org/D112180 that uses ValueCheck?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112537/new/
https://reviews.llvm.org/D112537
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
