mgorny added a comment. In D110447#3022340 <https://reviews.llvm.org/D110447#3022340>, @teemperor wrote:
> If you have the time, it would be nice to drop FIXME's above the few places > where the return value of `to_integer` is not checked. Those always make > great beginner bugs. Beginner? I'm pretty sure these things are really hard ;-). That said, in most of the cases 'not checking the return value' is combined with setting a fallback value earlier, i.e. if `llvm::to_integer()` fails, the variable remains with its default/fallback value. But yeah, I suppose it would be nice to rethink these things and maybe add explicit error handling in place of silent fallbacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110447/new/ https://reviews.llvm.org/D110447 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
