teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
This patch makes me very happy. I have one comment regarding one small change
in behaviour, but otherwise this LGTM.
If you have the time, it would be nice to drop FIXME's above the few places
where the return value of `to_integer` is not checked. Those always make great
beginner bugs.
================
Comment at: lldb/source/Symbol/SymbolContext.cpp:986
- m_end_line = StringConvert::ToSInt32(spec_string, 0, 0, &return_value);
- if (return_value)
m_type |= eLineEndSpecified;
----------------
This change and the one above make this return true on a parse failure. LLDB is
of course one step ahead of us here and never even checks the return value
anywhere (...), but I think it still makes sense to preserve the behaviour in
this patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110447/new/
https://reviews.llvm.org/D110447
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
