clayborg added a comment. In D107869#2940016 <https://reviews.llvm.org/D107869#2940016>, @OmarEmaraDev wrote:
> @jingham I wasn't arguing that we should remove those environment variables, > on the contrary. Greg was suggesting that we populate the environment field > with the target environment instead of implicitly adding them to the > environment of the launch info. The problem with that is that there is a > large number of environments that gets added (15 in my case) as shown in the > following screenshot. What I was saying in my comment above is that I don't > think we should show those to the user, we should transparently add them > instead and let the user add additional variables as needed. We can then look > into adding other settings to exclude them if necessary. I was actually suggesting only priming the env var list with what was contained in the "target.env-vars" setting. This doesn't include the extra env vars that are inherited. Just the ones that the user explicitly set. That defaults to nothing usually. If we go this way, then we should add a new boolean for inheriting the env vars that defaults to the current value of "target.inherit-env" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107869/new/ https://reviews.llvm.org/D107869 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
