jasonmolenda added a comment.
Sorry for not commenting on this on earlier, I wanted to think about it a bit.
I think the usefulness of this can depend on the type of logging. l often turn
on gdb-remote packet logging, or thread step logging, in an interactive debug
session and watch the log messages streaming as I do lldb commands. I think
interposing a JSON formatter in this is less straightforward - not that reading
JSON is that difficult, but it's just adding layering between me and the log
messages. WIth this patch the logging will be like {msg="..."} and fine, but
we'll add more fields to this over time and it will become less easy to read.
Maybe this can be an *option* to logging like verbose logging is. I don't have
any problem with the default mode being JSON and people who want rawness can
add an option to log enable to not do that.
I can't get too high and mighty with my philosophy of disintermediation --
gdb-remote packets are often actually using binary data, and even compressed,
and lldb reformats all of that before logging so my terminal doesn't get borked
by escape/high-bit characters being dumped on to it. But I read the gdb-remote
packet logs every day and wrapping it in JSON doesn't make anything better for
this use case, I don't think. This may be more a Jason opinion than a
gdb-remote packet reader opinion!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107079/new/
https://reviews.llvm.org/D107079
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
