aprantl added inline comments.
================ Comment at: lldb/include/lldb/Utility/ArchSpec.h:101 + // RISCV specific flags + enum RISCVflags { ---------------- In modern LLDB style we would format this as: ``` /// RISCV specific flags. enum class RISCVflags { arch_c = 0x00000001, ///< Some comment explaining what this is. abi_f = 0x00000010, ///< ... abi_d = 0x00000020 }; ``` ================ Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:1 +//===-- ABISysV_riscv.cpp ---------------------------------------*- C++ -*-===// +// ---------------- `-*- C++ -*-` markers only make sense for .h files, where the language is ambiguous. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits