JDevlieghere added a comment. Thanks for taking all the lore around API tests and writing it down. I think this is going to be very useful and make our lives easier during code review.
This LGTM but I won't accept (yet) to give others a chance to see this show up in their review queue. ================ Comment at: lldb/docs/resources/test.rst:215 + and it makes reproducing test failures on other operating systems or + configurations harder. There is usually + ---------------- Seems like the last sentence is incomplete? ================ Comment at: lldb/docs/resources/test.rst:229 + and makes the test much harder to debug and maintain. The test programs + should always be deterministic (i.e., do not generate and check against + random test values). ---------------- CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101153/new/ https://reviews.llvm.org/D101153 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
