dblaikie added inline comments.
================ Comment at: lldb/source/API/SBDebugger.cpp:857 + error = m_opaque_sp->GetTargetList().CreateTarget( + *m_opaque_sp, filename, arch, eLoadDependentsYes, platform_sp, + target_sp); ---------------- jingham wrote: > clayborg wrote: > > I submit with "arc diff" and it will cause lint errors if I don't allow it > > to fix the lint errors it finds. > I'm 100% not in favor of tools that force irrelevant changes to be included. > But that is a suggested tool so somebody must like that. They aren't forced - you can submit with linter errors if they don't seem helpful. Pre-committing format changes in standalone NFC commits would generally be preferable. & the linter shouldn't be flagging untouched lines - is it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97739/new/ https://reviews.llvm.org/D97739 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
