clayborg added inline comments.
================
Comment at: lldb/include/lldb/API/SBDebugger.h:46
+ static const char *GetBroadcasterClass();
+
----------------
@jingham: do we need this GetBroadcasterClass()? Or would this only be used to
listen to all debugger events as new debuggers are created? Also see my
question later that asks if we need the broadcast manager in the Broadcaster we
are using in the Debugger.h/Debugger.cpp.
================
Comment at: lldb/source/Core/Debugger.cpp:672
Properties(std::make_shared<OptionValueProperties>()),
+ Broadcaster(nullptr, GetStaticBroadcasterClass().AsCString()),
m_input_file_sp(std::make_shared<NativeFile>(stdin, false)),
----------------
@jingham: do we need to the m_broadcaster_manager_sp in this broadcaster?
Debugger inherits from Broadcaster, but we could change this to "has a" instead
of "is a" if we need the broadcast manager.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97739/new/
https://reviews.llvm.org/D97739
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
