thopre added a comment. In D98179#2621706 <https://reviews.llvm.org/D98179#2621706>, @davezarzycki wrote:
> I've made all of the requested changes to date. Two notes: > > 1. One cannot simply omit the first argument to `split()` if the second is > provided. As I just learned, python will complain. I switched the first > parameter to `None` as a compromise. > 2. For the record, I disagree with the use of the word "run" over "start" but > this isn't something that I care enough about to resist changing the patch. > Strictly speaking, `lit` only controls when tests start, not anything about > how they run. With enough cores, tests will complete in a fairly predictable > order despite any effort to start tests in a different order (or randomly). That's odd, the documentation <https://docs.python.org/3/library/stdtypes.html#string-methods> even contains such an example: For example: >>> >>> '1,2,3'.split(',') ['1', '2', '3'] >>> '1,2,3'.split(',', maxsplit=1) ['1', '2,3'] >>> '1,2,,3,'.split(',') ['1', '2', '', '3', ''] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98179/new/ https://reviews.llvm.org/D98179 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
