jhenderson added a comment. I've skimmed the implementation, and it looks good to me, but I haven't got the time right now to review thoroughly. I'm pleased to see the ease of implementing "only-failures" on top of this too, thanks for illustrating.
================ Comment at: llvm/utils/lit/lit/main.py:275 + path = os.path.join(s, '.lit_test_times.txt') + with open(path, 'w') as file: + for name, time in value: ---------------- `file` is a builtin python type, so don't use it as a variable name. Just call it `time_file` or something like that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98179/new/ https://reviews.llvm.org/D98179 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
