MaskRay added a comment.
In D94888#2505992 <https://reviews.llvm.org/D94888#2505992>, @labath wrote:
> It looks like this is removing the ability to build libc++ tests with gcc (as
> it does not have the `-stdlib` option). While having that ability would be
> nice, I don't believe there's anyone currently using that configuration, so
> it shouldn't stand in the way of other things. But we should also update the
> python detection code then (in `canRunLibcxxTests` in
> `packages/Python/lldbsuite/test/dotest.py` -- I guess you just need to remove
> the `if os.path.isdir("/usr/include/c++/v1"):` blurb)
>
> As for testing against the system libc++ with clang, I guess that should
> still work, as the extra rpath will be just ignored in that case...
I do not know whether the following few lines D9426
<https://reviews.llvm.org/D9426> were intentional.
CXXFLAGS += -isystem /usr/include/c++/v1
LDFLAGS += -lc++
For a proper setup, I think more stuff is needed. `/usr/include/c++/v1`
probably works for many Linux distributions but the choice doesn't look nice.
When libc++ is built with lldb, it probably use the libc++ include directory
instead. LDFLAGS will thus need a specific `-L`.
I think deleting the code until someone complains is fine? :)
> You seem to be removing more than adding there.
Can you kindly test this on NetBSD? :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94888/new/
https://reviews.llvm.org/D94888
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
