labath added a comment.

It looks like this is removing the ability to build libc++ tests with gcc (as 
it does not have the `-stdlib` option). While having that ability would be 
nice, I don't believe there's anyone currently using that configuration, so it 
shouldn't stand in the way of other things. But we should also update the 
python detection code then (in `canRunLibcxxTests` in 
`packages/Python/lldbsuite/test/dotest.py` -- I guess you just need to remove 
the `if os.path.isdir("/usr/include/c++/v1"):` blurb)

As for testing against the system libc++ with clang, I guess that should still 
work, as the extra rpath will be just ignored in that case...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94888/new/

https://reviews.llvm.org/D94888

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to