labath added inline comments.
================ Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.h:83 size_t GetDBROffset() const; + bool GetYMMSplitReg(uint32_t reg, void **xmm, void **ymm_hi); }; ---------------- mgorny wrote: > labath wrote: > > `void *&` > Are you sure about this? I feel like the whole `&` deal is quite confusing > (read: shouldn't have happened). You don't know whether the method modifies > the variables passed to it unless you look at the method prototype. well.. there certainly are code styles which prohibit non-const reference arguments. However, llvm is not one of them. Also lldb has a issue with compulsive null checks, so I think it's important to communicate the fact the two arguments cannot be null, which reference arguments do. Another possibility would be to just make this a real return value (pair<void *, void*> ?). The downside there is that it's not as self-documenting. Pick your poison... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91293/new/ https://reviews.llvm.org/D91293 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
