mgorny added inline comments.
================ Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:615 + if (offset == LLDB_INVALID_XSAVE_OFFSET) + return false; + ---------------- labath wrote: > When does this return false? When the ymm regs are not available? Yes. Note that this change brings us closer to being able to disable whole regsets — I just need to figure out how to do it ;-). ================ Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.h:83 size_t GetDBROffset() const; + bool GetYMMSplitReg(uint32_t reg, void **xmm, void **ymm_hi); }; ---------------- labath wrote: > `void *&` Are you sure about this? I feel like the whole `&` deal is quite confusing (read: shouldn't have happened). You don't know whether the method modifies the variables passed to it unless you look at the method prototype. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91293/new/ https://reviews.llvm.org/D91293 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
