ldionne added a comment. I quite like this. We should strive to use the same name as CMake uses for its build types, i.e. `Debug`, `Release`, etc.
If I configure CMake with `-DCMAKE_BUILD_TYPE=DEBUG`, is `CMAKE_BUILD_TYPE` normalized back to `Debug` by CMake, or is it defined to `DEBUG`? If the latter, then I suggest we might want to add a temporary error message when the `CMAKE_BUILD_TYPE` is defined to something all-uppercase. This would help catch cases where this patch will be a change in behavior. That would be a nice place to tell users to use the right build type names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89813/new/ https://reviews.llvm.org/D89813 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
