jasonmolenda added a subscriber: DavidSpickett.
jasonmolenda added a comment.
Thinking about process save-core and how it will default to a skinny corefile
on macOS but a full corefile elsewhere, I'd like to surface some notification
to the user about the type of corefile that was created to the user. Maybe add
an PluginManager::SavedCoreType {eSavedCoreFull, eSavedCoreDirtyOnly,
eSavedCoreDirtyPlusExecutingIMages}, have PluginManager::SaveCore return that
enum value so that the "process save-core" user command can print text about
the type of corefile that was saved. For a dirty corefile on macos, it could
say "Modified-memory-only corefile has been written. This corefile will not be
portable between systems, or usable as software updates are applied;
--full-corefile can create a corefile appropriate for sharing/archiving." or
something.
Also hoping that @DavidSpickett 's changes to qMemoryRegionInfo might land soon
so I don't cause conflicts with his patchset. :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88387/new/
https://reviews.llvm.org/D88387
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
