labath added a comment. Herald added a reviewer: JDevlieghere. (Sorry about the delay.) Given the current requirements, I think this patch is fine (excellent even).
That said, I'm not sure whether the original motivation for this requirement (avoiding dns lookups) is still relevant. These days, we communicate with the local debug server via `socketpair(2)` sockets (which wasn't the case back then), which does not require any dns lookups and is immune to a misconfigured hosts file. Given that none of the things touched by this patch is extremely critical (`GDBRemoteCommunication::ConnectLocally` is used for reproducers and the rest is test code), maybe we could use this to test the water and see whether we can start using the network stack the way it's supposed to be used ? ================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:1243 + std::error_code ec = e->convertToErrorCode(); + if (ec == std::make_error_code( + std::errc::address_family_not_supported) || ---------------- Nit: I believe the std::make_error_code call is redundant (direct comparison to the enum should work fine). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87333/new/ https://reviews.llvm.org/D87333 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
