labath added a comment.

In D85539#2216197 <https://reviews.llvm.org/D85539#2216197>, @JDevlieghere 
wrote:

> Even though this file is called "base", there's no inheritance going on here, 
> it's just methods and `lldbtest.py` will import the appropriate module. I 
> considered this too, but didn't feel like rewriting those files as a classes 
> for this small change. But if we're going to pass the `TRIPLE`, `OS` and 
> `VERSION` separately, we might as well.

I'd just send the final ARCH_CFLAGS value. Then the Android.rules makefile 
could be ported to python as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85539/new/

https://reviews.llvm.org/D85539

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to