labath added inline comments.
================
Comment at: lldb/source/Utility/Stream.cpp:178
+bool Stream::HasColors() const { return m_color_enabled; }
+
----------------
It looks like the only use for this function and the member variable is to
initialize the ColorEnabled field of the raw_ostream forwarder. Can we delete
this and pass the value via a constructor argument instead?
(I don't mind the method itself, just the fact that information on whether
colors are "enabled" is stored in two places (`m_color_enabled`,
`ColorEnabled`). The simplest way to fix that is to delete these things.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81058/new/
https://reviews.llvm.org/D81058
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
