labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed.
Let's talk about this more. I don't think we should cargo-cult code from llvm, especially when the cargo-culting won't actually work for the given use case. On windows, the `llvm::sys::Process::***` functions will be messing with the terminal which does not sound like a good thing to do from a generic place like this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81058/new/ https://reviews.llvm.org/D81058 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits