labath added a comment. In D78697#2001751 <https://reviews.llvm.org/D78697#2001751>, @aleksandr.urakov wrote:
> The problem here is that in the case of success `GetCString()` returns > `nullptr`, and we fail on concatenation with `None` even if the expression > was evaluated successfully. You should be able to use `str(sb_error)` In D78697#2001735 <https://reviews.llvm.org/D78697#2001735>, @teemperor wrote: > > I'm not very deep into the testing infrastructure, so I'm not sure that I > > am a right person to implement `assertSuccess` etc. Sorry about that. > > Sure, I don't think that was meant to be a suggested enhancement for this > specific line of patches. yep. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78697/new/ https://reviews.llvm.org/D78697 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
