teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

In D78697#2001751 <https://reviews.llvm.org/D78697#2001751>, @aleksandr.urakov 
wrote:

> The problem here is that in the case of success `GetCString()` returns 
> `nullptr`, and we fail on concatenation with `None` even if the expression 
> was evaluated successfully.


Oh true, totally missed that. I think we usually solved that by putting the 
assert in some 'if', but that's not much better than the wrapper. And this 
hopefully anyway goes away with the discussed utility method. So let's just 
leave it at that for now and no longer delay this patch.

LGTM, thanks for the quick turnaround!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78697/new/

https://reviews.llvm.org/D78697



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to