shafik added inline comments.
================ Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.cpp:8 + +CFBasicHash::CFBasicHash() + : m_ptr_size(UINT32_MAX), m_byte_order(eByteOrderInvalid), ---------------- Use in class member initializers please then you can use `=default` for the constructor this is more idiomatic modern C++ ================ Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.h:64 +private: + uint32_t m_ptr_size; + lldb::ByteOrder m_byte_order; ---------------- `uint32_t m_ptr_size = UINT32_MAX;` ================ Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.h:65 + uint32_t m_ptr_size; + lldb::ByteOrder m_byte_order; + ---------------- `lldb::ByteOrder m_byte_order = eByteOrderInvalid;` ================ Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.h:67 + + Address m_address; + ---------------- ` Address m_address = LLDB_INVALID_ADDRESS;` ================ Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.h:74 + + bool m_mutable; + bool m_multi; ---------------- These `bool` should have default values? I don't see them initialized. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78396/new/ https://reviews.llvm.org/D78396 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
