aprantl added inline comments.
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1362
+ case SDKType::AppleTVSimulator:
return version >= llvm::VersionTuple(8);
+ default:
----------------
The corresponding watchOS and tvOS numbers for iOS 8 should be lower, right? If
you are in doubt, just pick the current ones.
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1942
+ case unknown:
+ return "unknown";
+ }
----------------
empty stringref? That we can at least check for at the call site.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76261/new/
https://reviews.llvm.org/D76261
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
