[Lldb-commits] [PATCH] D76261: [lldb/PlatformMacOSX] Be more robust in computing the SDK path with xcrun

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1433
 
 FileSpec PlatformDarwin::GetSDKDirectoryForModules(SDKType sdk_type) {
   FileSpec sdks_spec = GetXcodeContentsPath();
----------------
aprantl wrote:
> Not your fault again, but I find the name of this function super confusing. 
> What is the :"ForModules" part supposed to mean?
It filters out SDK versions that don't support modules. We have something 
similar in SwiftASTContext, it only returns SDKs that support Swift. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76261/new/

https://reviews.llvm.org/D76261



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits