labath added inline comments.
================
Comment at: lldb/include/lldb/Host/DebugInfoD.h:26
+
+llvm::Error findSource(UUID buildID, const std::string &path,
+ std::string &result_path);
----------------
Expected<string> ?
================
Comment at: lldb/source/Host/common/DebugInfoD.cpp:43-67
+UUID getBuildIDFromModule(const ModuleSP &module) {
+ UUID buildID;
+
+ if (!module)
+ return buildID;
+
+ const FileSpec &moduleFileSpec = module->GetFileSpec();
----------------
How is all this different from `module->GetUUID()` ?
================
Comment at: lldb/source/Host/common/DebugInfoD.cpp:97
+ "debuginfod_find_source query failed: %s",
+ strerror(-rc));
+
----------------
llvm::sys::StrError(-rc)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75750/new/
https://reviews.llvm.org/D75750
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
