paolosev added a comment.

@JDevlieghere added inline comments:

> lldb/source/API/SystemInitializerFull.cpp 244
>  What's the rationale here? Plugins shouldn't rely on the order in which they 
> are initialized. This breaks when the initializers are auto generated. Can we 
> remove this dependency?

This was discussed in one of the comments above. If DynamicLoaderStatic 
preceeds DynamicLoaderWasmDYLD then it is recognized as a valid loader for a 
triple like "wasm32-unknown-unknown-wasm" because the Triple::OS is 
llvm::Triple::UnknownOS.
There is an explicit check for UnknownOS in 
DynamicLoaderStatic::CreateInstance().
Should ProcessGDBRemote::GetDynamicLoader behave differently just when the 
architecture is wasm32, as a workaround?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72751/new/

https://reviews.llvm.org/D72751



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to