labath added a reviewer: JDevlieghere.
labath added a comment.
This moves a lot of lldb-specific stuff out of low-level dwarf code, and as
such, I think this is a great step towards the parser unification.
I'd just like to squeeze one interface tweak to function we are moving around,
but otherwise, I think this is fine.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4011
+void SymbolFileDWARF::GetDWARFDeclContext(const DWARFDIE &die,
+ DWARFDeclContext &dwarf_decl_ctx) {
+ if (!die.IsValid()) {
----------------
please return the DWARFDeclContext by value here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70646/new/
https://reviews.llvm.org/D70646
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
