labath added a comment.

> @labath, maybe this is the only patch you did mean?

This is (more or less -- I can't say I had a really exact picture in my head) 
what I had in mind, when I said that moving the high-level code out of the 
DWARFUnit class would be useful for the llvm<->lldb dwarf parser convergence. I 
am aware that you need more for the DWZ stuff -- that is fine, and I like that 
you have split that into a separate patch.

Anyway, I think this is a good direction to move in. When the time comes, I'd 
like to get some of clang ast folks to give this a look too, but maybe that's 
not needed yet...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70646/new/

https://reviews.llvm.org/D70646



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to