labath added a reviewer: aprantl. labath added a comment. Thanks for splitting this off.
This looks good except that I wouldn't want to put this under the base `TestingSupport` folder -- the idea there was that this would contain only the basic stuff with no fancy dependencies (so that e.g. UtilityTests don't depend on everything). Here, you've put everything inline, which kind of hides this, but now that this is a separate file, it would make sense to put some of this stuff into a .cpp file (e.g. YamlObjectFile, YamlModule classes, and the YAMLModuleTester constructor). The exact layout of the folders under TestingSupport is still evolving, and although one could argue that this should go under TestingSupport/SymbolFile/DWARF, that is quite a mouthful, and so I think we can just shove this under the existing TestingSupport/Symbol folder (with the rationale that SymbolFile, base class of SymbolFileDWARF, lives in the Symbol folder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73279/new/ https://reviews.llvm.org/D73279 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
