labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Seems reasonable.
================
Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:52
+# Any overridden settings.
+settings = []
+
----------------
JDevlieghere wrote:
> To initialize settings to a empty dictionary this should be `{}` or `dict()`.
True, though that depends on what you really want out of this. I can see how
executing the commands in the order that the user set them could be more
predictable....
================
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:787
+def disabledynamics():
+ setSetting('target.prefer-dynamic-value', 'no-dynamic-values')
----------------
Maybe you could even put this as the default value for the `settings` variable?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72662/new/
https://reviews.llvm.org/D72662
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
