labath added inline comments.
================ Comment at: lldb/include/lldb/Symbol/TypeSystem.h:201 + virtual llvm::Optional<std::string> + GetClassName(const CompilerType &compiler_type) = 0; + ---------------- I'm confused by the CompilerType argument here. It seems odd as the CompilerType object already contains a type system. Though we seem to have some precedent for this, the majority of TypeSystem functions seems to take an `opaque_compiler_type_t` (and this seems reasonable to me -- the user would call `CompilerType::GetClassName`, which would then forward the call to `m_type_system->GetClassName(m_opaque_ptr)`...). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69820/new/ https://reviews.llvm.org/D69820 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
