jingham added inline comments.
================
Comment at: lldb/source/Core/ValueObject.cpp:2056
+ if (parent_had_base_class)
+ s.PutCString("::");
+ s.PutCString(class_name.getValue());
----------------
xiaobai wrote:
> jingham wrote:
> > That's still implicitly C. Other languages (swift) use "." for the same
> > purposes. If this is really language agnostic we either need a
> > "GetSeparator" function, or we need s "ComposePath" operation from the
> > language.
> Yep, it is. We would need to get the language plugin for whatever we're
> dealing with. There might be a decent way to get to that by getting the
> LanguageType from the CompilerType, and trying to find a plugin for that (and
> some default separator for languages that don't have a plugin). Definitely
> worth doing.
>
> I think adding a "GetClassSeparator" method in this patch would stray from
> the purpose of this patch, so I'd like to do that in a follow-up if possible.
FBM, but can you at least leave a FIXME here so if you don't get to the
follow-up right away it's clear this still needs to be done?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69820/new/
https://reviews.llvm.org/D69820
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
