xiaobai added inline comments.

================
Comment at: lldb/test/Shell/Settings/Inputs/main.cpp:95
+
+    //virtual
+    ~C()
----------------
nit: comment unneeded.


================
Comment at: lldb/test/Shell/Settings/TestFrameFormatMangling.test:9
+frame info
+# CHECK: frame #0: {{.*}}_ZN1CC2Eiii
+c
----------------
jasonmolenda wrote:
> Is this mangled name going to be the same on windows?
This will definitely be different on windows, so this will fail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71237/new/

https://reviews.llvm.org/D71237



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to