[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

[Alex Langford via Phabricator via lldb-commits]

xiaobai added inline comments.


================
Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/CMakeLists.txt:10
+find_package(Lua REQUIRED)
+include_directories(${LUA_INCLUDE_DIR})
+
----------------
Nit: I would use `target_include_directories` here.

https://cmake.org/cmake/help/latest/command/target_include_directories.html


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71234/new/

https://reviews.llvm.org/D71234



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits