labath added a comment.
This looks better. Ideally I wouldn't even have Utility/GDBRemote.h, but as
Process/gdb-remote is not a very good place for it either (it messes with
lldb-server dependencies), we can live with it for now.
================
Comment at: lldb/include/lldb/Utility/Reproducer.h:23
namespace lldb_private {
+struct GDBRemotePacket;
namespace repro {
----------------
I guess this should not be needed anymore?
================
Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:439
- std::vector<GDBRemotePacket> packets;
- yaml::Input yin((*error_or_file)->getBuffer());
- yin >> packets;
+ static std::unique_ptr<repro::MultiLoader<repro::GDBRemoteProvider>>
+ multi_loader =
----------------
So what about this `static` thing?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71105/new/
https://reviews.llvm.org/D71105
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
