teemperor added a comment. Could this return an `Optional<std::string>` or `Expected<std::string>`? It's not clear from a `std::string` return value that the method can fail and it will return an empty string on error.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69641/new/ https://reviews.llvm.org/D69641 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
