JosephTremoulet marked 2 inline comments as done.
JosephTremoulet added inline comments.
================
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:219-237
+
+ if (arch.GetTriple().isOSLinux()) {
+
+ SetUnixSignals(UnixSignals::Create(GetArchitecture()));
+
+ if (!m_thread_list.empty() &&
+ (!m_active_exception ||
----------------
JosephTremoulet wrote:
> labath wrote:
> > Would it be possible to move this code (except maybe the SetUnixSignals
> > bit) into the `RefreshStateAfterStop` function? Would be less confusing and
> > it would avoid the need for extra member variables...
> Yeah, happy to. I wasn't sure what the implications of doing so would be,
> but I guess for a dump file there will only ever be one stop?
I've moved it. In doing so I left the early-out for `!m_active_exception`,
which is a behavioral difference from my previous iteration, but this covers my
use-case so I think better to keep the change focused like this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68096/new/
https://reviews.llvm.org/D68096
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
