compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Honestly, this is just setting up the register context for ARM64. I dont think
that there is much of a test for this. I mean, I suppose you could test this
by instantiating the context and trying to read it through the interface. But,
I question the value of such a test. Whether you go with the in-process or
out-of-process approach and whether you are doing DWARF of CodeView debugging
this is going to be needed. As to running the test suite - you can
cross-compile and run the tests remotely.
================
Comment at:
lldb/source/Plugins/Process/Windows/Common/arm64/RegisterContextWindows_arm64.cpp:57
+ gpr_x21, gpr_x22, gpr_x23, gpr_x24, gpr_x25, gpr_x26, gpr_x27,
+ gpr_x28, gpr_fp, gpr_lr, gpr_sp, gpr_pc, gpr_cpsr};
+
----------------
It formats better if you add a trailing comma to the list (`gpr_cpsr,`)
================
Comment at:
lldb/source/Plugins/Process/Windows/Common/arm64/RegisterContextWindows_arm64.cpp:64
+ fpu_v21, fpu_v22, fpu_v23, fpu_v24, fpu_v25, fpu_v26, fpu_v27,
+ fpu_v28, fpu_v29, fpu_v30, fpu_v31, fpu_fpsr, fpu_fpcr};
+
----------------
Similar
================
Comment at:
lldb/source/Plugins/Process/Windows/Common/arm64/RegisterContextWindows_arm64.cpp:70
+ {"Floating Point Registers", "fpu",
+ llvm::array_lengthof(g_fpu_reg_indices), g_fpu_reg_indices}};
+
----------------
Similar
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67954/new/
https://reviews.llvm.org/D67954
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
