probinson added a comment. Removing that llvm_unreachable is fine, in that case. The idea for error handling for DataExtractor sounds reasonable, looks like adding an error flag wouldn't even increase the size.
Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63591/new/ https://reviews.llvm.org/D63591 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits