labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good to me now. Thanks for your patience.
================
Comment at:
lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationServerTest.cpp:1-2
+//===-- GDBRemoteGDBRemoteCommunicationServerTest.cpp --------------------*-
C++
+//-*-===//
+//
----------------
This line wrapped accidentally.
================
Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteTestUtils.h:28
+public:
+ MockConnection(std::vector<std::string> *packets) { m_packets = packets; };
+
----------------
A reference would be slightly better, as it is implicitly non-null.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62499/new/
https://reviews.llvm.org/D62499
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
