aadsm marked an inline comment as done.
aadsm added inline comments.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2766
// Grab the auxv data.
auto buffer_or_error = m_debugged_process_up->GetAuxvData();
if (!buffer_or_error) {
----------------
@labath, I was thinking about the auto rule and I'm not sure how it would play
here. I remember having to check the GetAuvData to know what this was
returning. However, it's quite verbose but I have found instances like this in
the codebase:
```
ErrorOr<std::unique_ptr<WritableMemoryBuffer>> buf =
llvm::WritableMemoryBuffer::getNewMemBuffer(auxv_size);
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62499/new/
https://reviews.llvm.org/D62499
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
