clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed.
Just fix the return when we have a DW_AT_signature and this is good to go. ================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:267 + } + } + ---------------- We should return before the } on line 267, not on line 265. If we have a DW_AT_signature and we fail to parse a type we won't do any better below when there is no type info right? ================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:74 + std::vector<std::pair<uint64_t, uint32_t>> m_type_hash_to_unit_index; + ---------------- llvm::DenseMap? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62246/new/ https://reviews.llvm.org/D62246 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
