jryans marked 3 inline comments as done. jryans added a comment. Thanks all for the review! đ
In D61877#1500981 <https://reviews.llvm.org/D61877#1500981>, @sgraenitz wrote: > Thanks for adding this. Would it make sense to use > `LLVM_ENABLE_PROJECTS_USED`? > https://github.com/llvm/llvm-project/blob/a568222d/llvm/CMakeLists.txt#L128 > > BTW `LLVM_ENABLE_PROJECTS` can be "all" but LLVM should already have handled > it at this point. `LLVM_ENABLE_PROJECTS_USED` seems to be about "what did we use last time", which felt confusing to test here, so I have avoided that so far. In the updated version, I have changed to testing `if(NOT TARGET cxx)`, which should cover all cases, including: - LLVM_ENABLE_PROJECTS='clang;lldb;libcxx' - LLVM_ENABLE_PROJECTS='all' - Old layout ================ Comment at: lldb/CMakeLists.txt:127 else() + if(NOT libcxx IN_LIST LLVM_ENABLE_PROJECTS) + message(FATAL_ERROR ---------------- sgraenitz wrote: > JDevlieghere wrote: > > Should we check that LLVM_ENABLE_PROJECTS is not empty, for people that are > > still using the old layout? > +1 Ah yes, thanks for catching that! I have updated this to support the old layout as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61877/new/ https://reviews.llvm.org/D61877 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
