sgraenitz added a comment.

Thanks for adding this. Would it make sense to use `LLVM_ENABLE_PROJECTS_USED`? 
https://github.com/llvm/llvm-project/blob/a568222d/llvm/CMakeLists.txt#L128

BTW `LLVM_ENABLE_PROJECTS` can be "all" but LLVM should already have handled it 
at this point.



================
Comment at: lldb/CMakeLists.txt:127
       else()
+        if(NOT libcxx IN_LIST LLVM_ENABLE_PROJECTS)
+          message(FATAL_ERROR
----------------
JDevlieghere wrote:
> Should we check that LLVM_ENABLE_PROJECTS is not empty, for people that are 
> still using the old layout?
+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61877/new/

https://reviews.llvm.org/D61877



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to