labath added inline comments.
================ Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:891-892 + + if (!CreateBinary()) + return UUID(); + auto COFFObj = ---------------- Hui wrote: > labath wrote: > > I don't think this is necessary as `CreateInstance` will refuse to return > > the ObjectFile instance if the creation of the coff binary object failed. > > (You could theoretically assert that the binary is really there if you want > > extra security). > There is no cached binary for memory instance (by CreateMemoryInstance). Is > there any chance that any JIT-ed codes will call module or UUID related API? Ah, interesting. Yes, if you manage to create a memory instance of ObjectFilePECOFF, then there's a very high chance that someone will call GetUUID on it. I strongly doubt that anyone is creating memory instances, or that they even work in the first place, but I suppose we can leave this check just in case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
