Hui added inline comments.
================ Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:891-892 + + if (!CreateBinary()) + return UUID(); + auto COFFObj = ---------------- labath wrote: > I don't think this is necessary as `CreateInstance` will refuse to return the > ObjectFile instance if the creation of the coff binary object failed. (You > could theoretically assert that the binary is really there if you want extra > security). There is no cached binary for memory instance (by CreateMemoryInstance). Is there any chance that any JIT-ed codes will call module or UUID related API? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56229/new/ https://reviews.llvm.org/D56229 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
