labath marked an inline comment as done.
labath added inline comments.
================
Comment at: lib/ObjectYAML/MinidumpYAML.cpp:91
+
size_t BlobAllocator::allocateString(StringRef Str) {
SmallVector<UTF16, 32> WStr;
----------------
clayborg wrote:
> Might be nice to unique the strings in here?
Yeah, that would be possible, but it does not seem worth the trouble at the
moment. However, I do have some ideas about reusing this code for saving
minidump snapshots from within lldb (right now that is only supported on
windows, by delegating to some windows APIs). At that point it may become more
important to generate more compact minidump representations.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60405/new/
https://reviews.llvm.org/D60405
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
